Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Club approval response templates #739

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Conversation

rm03
Copy link
Member

@rm03 rm03 commented Oct 15, 2024

This PR introduces a new feature that enables site administrators to efficiently manage templated responses for the club approval/rejection process. Admins can now create, update, and select predefined templates when approving or rejecting clubs (works for individual or bulk approvals/rejections). This feature replaces the manual task of copying and pasting responses, reducing overhead and ensuring consistent messaging

Template management tab on admin dashboard:
image

Template dropdown on club page:
image

Template dropdown on queue page for bulk approvals/rejections:
image

@rm03 rm03 force-pushed the club-approval-response-templates branch from 380eac7 to c9f36cb Compare October 15, 2024 05:51
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.80%. Comparing base (ca77e21) to head (3f606f3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
backend/clubs/models.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #739      +/-   ##
==========================================
+ Coverage   71.68%   71.80%   +0.11%     
==========================================
  Files          31       31              
  Lines        6870     6901      +31     
==========================================
+ Hits         4925     4955      +30     
- Misses       1945     1946       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rm03 rm03 marked this pull request as ready for review October 15, 2024 19:09
Copy link
Member

@aviupadhyayula aviupadhyayula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is sick, great work Rohan. Backend code LGTM. About the frontend: do we plan to support someone applying multiple templates to the same approval decision? I can envision a club getting rejected for multiple reasons (e.g. a club's name has Penn in it, and it doesn't have enough members).

backend/tests/clubs/test_views.py Show resolved Hide resolved
@rm03
Copy link
Member Author

rm03 commented Oct 15, 2024

This is sick, great work Rohan. Backend code LGTM. About the frontend: do we plan to support someone applying multiple templates to the same approval decision? I can envision a club getting rejected for multiple reasons (e.g. a club's name has Penn in it, and it doesn't have enough members).

Just added this, if one of you can test locally and let me know if it works that would be great 🙂

Copy link
Member

@julianweng julianweng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, some code duplication is acceptable given the scale so LGTM!

@rm03 rm03 force-pushed the club-approval-response-templates branch from ebe0bc9 to 3f606f3 Compare October 16, 2024 02:24
@rm03 rm03 merged commit 715ba15 into master Oct 16, 2024
8 checks passed
@rm03 rm03 deleted the club-approval-response-templates branch October 16, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants